Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scroll with ids, have pdf view toggle, share buttonset styling #958

Merged
merged 6 commits into from
Apr 4, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 4, 2023

Description

  • Table of contents anchors work and pdf preview page is togglable.
  • Cleaned up styling
  • Empty footers from the sidebars appeared and the whole page locks a bit down once you click a scroll anchor. In order to fix this I did display: none when tera-slider footer has no content.
Screen.Recording.2023-04-04.at.3.25.43.PM.mov

@shawnyama shawnyama changed the title scroll with refs, have pdf view toggle, share buttonset styling feat: scroll with refs, have pdf view toggle, share buttonset styling Apr 4, 2023
@shawnyama shawnyama marked this pull request as ready for review April 4, 2023 19:31
@shawnyama shawnyama changed the title feat: scroll with refs, have pdf view toggle, share buttonset styling feat: scroll with ids, have pdf view toggle, share buttonset styling Apr 4, 2023
@shawnyama shawnyama merged commit 838eee0 into main Apr 4, 2023
@shawnyama shawnyama deleted the extraction-scroll branch April 4, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants