Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adobe pdf viewer integration #966

Merged
merged 8 commits into from
Apr 21, 2023
Merged

feat: adobe pdf viewer integration #966

merged 8 commits into from
Apr 21, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 5, 2023 •
edited
Loading

Description

You can view the PDF in Document.vue

Screen.Recording.2023-04-05.at.3.35.49.PM.mov

Followed this and related articles: https://www.raymondcamden.com/2022/09/30/using-the-adobe-pdf-embed-api-with-vue-3

@shawnyama shawnyama marked this pull request as ready for review April 5, 2023 19:28
@shawnyama shawnyama linked an issue Apr 5, 2023 that may be closed by this pull request
[FEAT]: Open PDF files within the Document.vue #959
Closed
YohannParis
YohannParis reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add info in the DEVELOPMENT.md file about adding the API key in the .env file.

@shawnyama shawnyama requested a review from YohannParis April 6, 2023 20:10
YohannParis
YohannParis reviewed Apr 6, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is almost good to go, I'm just thinking because this will be in the front-end, we don't care about encoding the API key.
So we will get one and just add it to this PR.

YohannParis
YohannParis approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers !

@YohannParis YohannParis merged commit 6f274ff into main Apr 21, 2023
@YohannParis YohannParis deleted the pdf-viewer branch April 21, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwdchang mwdchang mwdchang left review comments

@YohannParis YohannParis YohannParis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Open PDF files within the Document.vue
3 participants
@shawnyama @YohannParis @mwdchang