Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: meta asset component #986

Merged
merged 28 commits into from
Apr 21, 2023
Merged

feat: meta asset component #986

merged 28 commits into from
Apr 21, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Apr 11, 2023 •
edited
Loading

Description

Created tera-asset.vue which provides a shared header and general styling for all asset components. asset.scss has been deleted and its styles were distributed to tera-asset.vue or if the style was specific to the asset it was moved to that asset component.

@shawnyama shawnyama linked an issue Apr 12, 2023 that may be closed by this pull request
[TASK]: throw a lot of the similar things from model/document/simulation ect into reusable components #968
Closed
@shawnyama shawnyama marked this pull request as ready for review April 13, 2023 18:00
@YohannParis
Copy link
Member

Could you make the code.vue use tera-asset as well.

@shawnyama shawnyama marked this pull request as draft April 17, 2023 20:54
@shawnyama
Copy link
Contributor Author

shawnyama commented Apr 20, 2023 •
edited
Loading

Approve this branch before approving this
(Done)

@shawnyama shawnyama requested review from YohannParis and echl April 20, 2023 14:28
@shawnyama shawnyama marked this pull request as ready for review April 20, 2023 14:29
YohannParis
YohannParis approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tera-asset.vue and tera-asset-nav.vue could be in an src/components/asset/ folder instead of widget now.

@shawnyama shawnyama merged commit 1425f6e into main Apr 21, 2023
@shawnyama shawnyama deleted the tera-asset branch April 21, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echl echl echl approved these changes

@YohannParis YohannParis YohannParis approved these changes

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@tangopapatime tangopapatime Awaiting requested review from tangopapatime

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK]: throw a lot of the similar things from model/document/simulation ect into reusable components
3 participants
@shawnyama @YohannParis @echl