Skip to content

Commit

Permalink
chore: re-enable integration tests (open-feature#146)
Browse files Browse the repository at this point in the history
Update test harness and re-enable integration test profile
  • Loading branch information
toddbaert authored Oct 13, 2022
1 parent d7fabaf commit 5da9182
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pullrequest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
${{ runner.os }}-maven-
- name: Build with Maven
run: mvn --batch-mode --update-snapshots verify # -P integration-test - add this back once we have a compatible flagd
run: mvn --batch-mode --update-snapshots verify -P integration-test

- name: Upload coverage to Codecov
uses: codecov/codecov-action@e0fbd592d323cb2991fb586fdd260734fcb41fcb
Expand Down
7 changes: 7 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,13 @@
<version>31.1-jre</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>dev.openfeature.contrib.providers</groupId>
<artifactId>flagd</artifactId>
<version>0.4.1</version>
<scope>test</scope>
</dependency>
</dependencies>

<dependencyManagement>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;

// import dev.openfeature.contrib.providers.flagd.FlagdProvider;
import dev.openfeature.contrib.providers.flagd.FlagdProvider;
import dev.openfeature.sdk.Client;
import dev.openfeature.sdk.FlagEvaluationDetails;
import dev.openfeature.sdk.MutableStructure;
Expand Down Expand Up @@ -45,7 +45,7 @@ public class StepDefinitions {

@BeforeAll()
public static void setup() {
// OpenFeatureAPI.getInstance().setProvider(new FlagdProvider());
OpenFeatureAPI.getInstance().setProvider(new FlagdProvider());
client = OpenFeatureAPI.getInstance().getClient();
}

Expand Down
2 changes: 1 addition & 1 deletion test-harness

0 comments on commit 5da9182

Please sign in to comment.