ci: skip some tests for Python 3.8

DC-analysis · Oct 28, 2023 · 301285a · 301285a
1 parent de7fedb
commit 301285a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -14,10 +14,11 @@ jobs:
         os: [macos-latest, ubuntu-latest, windows-latest]
         extras: ['all', 'dcor-s3', 'none']
         exclude:
-          # probably due to dependency issues, s3 tests keep hanging here
+          # urllib3>=2 is required, dependency conflict
           - python-version: '3.8'
-            os: windows-latest
             extras: 'all'
+          - python-version: '3.8'
+            extras: 'dcor-s3'
       fail-fast: false
     timeout-minutes: 30
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -52,7 +52,7 @@ export = ["fcswrite>=0.5.0",  # fcs export
 ]
 lme4 = ["rpy2>=2.9.4"]
 ml = ["tensorflow>=2.0"]
-s3 = ["s3fs>=2023.10.0"]
+s3 = ["s3fs>=2023.10.0", "urllib3>=2"]
 tdms = ["imageio[ffmpeg]", "nptdms>=0.23.0"]