Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure basins are not forgotten when running CLI methods (e.g. dclab-compress) #239

Closed
paulmueller opened this issue Oct 12, 2023 · 3 comments
Closed

Make sure basins are not forgotten when running CLI methods (e.g. dclab-compress) #239

paulmueller opened this issue Oct 12, 2023 · 3 comments
Labels
bug tests

Comments

@paulmueller
Copy link
Member

paulmueller commented Oct 12, 2023 •
edited
Loading

These CLI commands should include basin definitions: compress, condense, repack
This CLI command should include mapped basin definitions: split
This CLI command should not include basin definitions: join
@NadiaSbaa
Copy link
Contributor

We have implement the test function test_basin_preserved_compress() here

@paulmueller paulmueller mentioned this issue Jan 17, 2024
Closed
@paulmueller
Copy link
Member Author

paulmueller commented Jan 17, 2024 •
edited
Loading

Added the bug label, since this is actually not correctly implemented at all.

[EDIT: It was actually implemented correctly, the test function we came up with copied over scalar features which is why it did not actually test the thing]

paulmueller added a commit that referenced this issue Apr 1, 2024
@paulmueller
overhaul CLI methods and related functionality
abc9c44 
 - fix: support input files without "events" in `rtdc_copy`
 - fix: CLI methods now store basin information in output paths (#239):
   compress, condense, and repack preserve the original input basins;
   split writes mapped basins (using export.hdf5); join does not write
   basins at all
 - enh: CLI methods now return the output path
 - enh: the repack CLI method now allows to strip basins
 - docs: update doc strings for CLI methods
 - ref: put input and output path in order for CLI methods
@paulmueller
Copy link
Member Author

closed in abc9c44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmueller @NadiaSbaa