Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SwitchPanel PZ55 Serialize] Makes SwitchPanel Pz55 Serializable #492

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Mutex666
Copy link
Collaborator

@Mutex666 Mutex666 commented Mar 1, 2024

  • Simplify properties to auto properties in PZ55 Panel.
  • Makes all The switchPanel properties PZ55 Serializable
  • Add PanelPz55 Serialize test & JSon Example of serialized Panel

Notes:

  • Custom ImportSettings/ ExportSettings is unchanged. No changes in current behavior of the panel.
  • Not deserialize tests for the moment because on how panel are instanciated with a HidSkeletton & HidInstance. Must find a way around that a little later.

Full panels serialization in JSon is more of a proof of concept than anything else for the moment. This is the first step. Could be discarded at any moment if it becomes too complicated or not realizable.

We still have the benefits of the individual componnents serialization tests and we could eventually replace the cutom import / exports settings of those. But better try to make it work on the full panels to get the full benefits.

@Mutex666 Mutex666 requested a review from jdahlblom March 1, 2024 05:32
@jdahlblom jdahlblom merged commit 3a2dc25 into main Mar 1, 2024
3 checks passed
@jdahlblom jdahlblom deleted the feature/switch-panel-pz55-serialize branch March 1, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants