Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/100] sns 공유하기, 에러페이지 #101

Merged
merged 9 commits into from
Aug 27, 2024
Merged

Conversation

hwanheejung
Copy link
Member

👀 관련 이슈

#100

✨ 작업한 내용

  • kakao, instagram, X, facebook 공유하기
  • 에러페이지 UI

🌀 PR Point

  • 수정할 부분이 있거나 더 좋은 방법이 있으면 알려주세요!

🍰 참고사항

  • 카카오 공유하기는 배포 후에 확인이 가능합니다
  • env 파일에 NEXT_PUBLIC_KAKAO_API_KEY 추가해주세요 디스코드에 올려놓겠습니다
  • 공유하기는 배포되면 다양한 기기에서 계속 테스트해보면서 수정해야 할 것 같습니다
  • 보드 이미지 저장은 아직입니다..!

📷 스크린샷 또는 GIF

기능 스크린샷
공유 팝업 스크린샷 2024-08-26 오후 9 52 11

@hwanheejung hwanheejung linked an issue Aug 26, 2024 that may be closed by this pull request
2 tasks
@hwanheejung hwanheejung requested a review from junseublim August 26, 2024 12:57
@hwanheejung hwanheejung self-assigned this Aug 26, 2024
@@ -0,0 +1,49 @@
import { ComponentProps, MouseEventHandler, ReactNode } from 'react'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공유 관련 컴포넌트들을 하나의 폴더에 모으면 좋을 것 같아요.

  • Share/

    • index.tsx
    • ShareSection.tsx
    • ShareModal.tsx

    대략 이런 구조면 어떨까요?(꼭 동일할 필요는 없습니다!)

Copy link
Collaborator

@junseublim junseublim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hwanheejung hwanheejung merged commit 5d0710f into develop Aug 27, 2024
@hwanheejung hwanheejung deleted the feature/100 branch August 27, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 보드 공유 팝업, 에러페이지
2 participants