Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

폴라로이드 꾸미기 기능 추가 #121

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Conversation

junseublim
Copy link
Collaborator

✨ 작업한 내용

폴라로이드 꾸미기 기능을 추가했습니다.

🌀 PR Point

  • 코드 개선 사항있으면 알려주세요!

🍰 참고사항

  • CreatePolaroidModal 구조랑 css가 많이 수정되었습니다. 참고 부탁드립니다!

📷 스크린샷 또는 GIF

기능 스크린샷
폰트 선택 스크린샷 2024-09-24 오후 11 45 07
테마 선택 스크린샷 2024-09-24 오후 11 45 11

Copy link
Member

@hwanheejung hwanheejung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍 코멘트 단거 하나만 확인해주시고 머지해도 될 것 같습니다!

  • ResizeObserver는 처음보는데 신기하네요..! 😲

@@ -78,14 +84,18 @@ const PolaroidMaker = ({
}

return (
<PolaroidFrame className="mx-auto flex w-[272px] touch-pinch-zoom flex-col overflow-y-hidden">
<PolaroidFrame
className={twJoin('mx-auto flex flex-col overflow-y-hidden')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

twJoin 빼도 될 것 같습니다!

@junseublim junseublim merged commit 0f9272a into develop Sep 25, 2024
@junseublim junseublim deleted the feature/polaroid-design branch September 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants