Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/124] 4-1μ°¨ QA #125

Merged
merged 5 commits into from
Sep 27, 2024
Merged

[Fix/124] 4-1μ°¨ QA #125

merged 5 commits into from
Sep 27, 2024

Conversation

hwanheejung
Copy link
Member

πŸ‘€ κ΄€λ ¨ 이슈

#124

✨ μž‘μ—…ν•œ λ‚΄μš©

  • ν΄λΌλ‘œμ΄λ“œ ν…Œλ§ˆμ„ νƒ μ²΄ν¬ν‘œμ‹œ
  • λͺ¨λ‹¬ 슀크둀 방지
  • μ—…λ‘œλ“œ λͺ¨λ‹¬ 문ꡬ변경
  • ν΄λΌλ‘œμ΄λ“œ 상세-λ°μŠ€ν¬νƒ‘μ—μ„œ λ²„νŠΌ

πŸŒ€ PR Point

μˆ˜μ •ν•  λΆ€λΆ„ 있으면 μ•Œλ €μ£Όμ„Έμš”!

@hwanheejung hwanheejung linked an issue Sep 26, 2024 that may be closed by this pull request
4 tasks
@@ -56,7 +56,7 @@ const CreatePolaroid = ({
}, [fontSelectRef, showFontSelect])

return (
<div className="relative flex h-dvh w-full max-w-md touch-pan-y flex-col items-center justify-between">
<div className="relative flex h-dvh w-full max-w-md touch-none flex-col items-center justify-between bg-gray-900/80">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κΈ°μ‘΄ λͺ¨λ‹¬μ˜ λ°°κ²½μ΄λž‘ κ²Ήμ³μ„œ 더 μ–΄λ‘μ›Œμ§„ κ±° κ°™μ•„μš”. λ””μžμ΄λ„ˆλΆ„λ“€κ³Ό μƒμ˜ν•΄μ„œ κΈ°μ‘΄ λͺ¨λ‹¬μ˜ 배경색을 80으둜 ν†΅μΌν•˜κ±°λ‚˜ 뢈투λͺ…도λ₯Ό 쑰금 μ‘°μ •ν•˜λŠ”κ²Œ λ‚˜μ„ κΊΌ κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„λ‹ˆλ©΄ κ·Έλƒ₯ bg-gray-900/50을 μ μš©ν•˜λ©΄ λ‘˜μ΄ κ³„μ‚°ν•΄μ„œ 뢈투λͺ…도가 80%으둜 κ°€λŠ₯ν•  것 κ°™λ„€μš”!
(0.4 * 0.5 = 0.2)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThemaSelect μ»΄ν¬λ„ŒνŠΈμ—λ„ λ™μΌν•˜κ²Œ μ μš©λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

Copy link
Collaborator

@junseublim junseublim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwanheejung hwanheejung merged commit 9216511 into develop Sep 27, 2024
@hwanheejung hwanheejung deleted the fix/124 branch September 27, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] 4-1μ°¨
2 participants