Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/23] 폴라로이드 생성 모달, 로딩 #24

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Conversation

hwanheejung
Copy link
Member

👀 관련 이슈

#23

✨ 작업한 내용

  • 폴라로이드 생성할때 페이지->모달로 변경했습니다
  • 로딩 컴포넌트 생성했습니다

🌀 PR Point

수정해야 할 부분이나 더 나은 구현 방법이 있으면 말씀해주세요!

🍰 참고사항

  • 서버 컴포넌트에서 모달 구현하는 과정에서 현재 경로가 필요해서 middleware.ts 파일 생성했습니다
  • 피그마 상에서 필터 적용 로딩화면이 있는데, 바로 적용이 돼서 일단 주석처리해두었습니다 (디자이너님들께 전달했습니다)
  • 보드 생성 Loading 화면에 해당 컴포넌트 적용해두었습니다.

📷 스크린샷 또는 GIF

기능 스크린샷
모달 화면 기록 2024-07-10 오전 4 33 12
로딩 image

@hwanheejung hwanheejung linked an issue Jul 9, 2024 that may be closed by this pull request
2 tasks
@hwanheejung hwanheejung self-assigned this Jul 9, 2024
@hwanheejung hwanheejung added the enhancement New feature or request label Jul 9, 2024
Copy link
Collaborator

@junseublim junseublim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

질문 하나 남겼습니다!

src/middleware.ts Show resolved Hide resolved
Copy link
Collaborator

@junseublim junseublim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwanheejung hwanheejung merged commit f9382f0 into develop Jul 10, 2024
@hwanheejung hwanheejung deleted the feature/23 branch July 10, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 폴라로이드 생성 모달, 필터 적용 로딩화면
2 participants