Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/32] 홈페이지 구현 #34

Merged
merged 4 commits into from
Jul 16, 2024
Merged

[Feature/32] 홈페이지 구현 #34

merged 4 commits into from
Jul 16, 2024

Conversation

junseublim
Copy link
Collaborator

👀 관련 이슈

✨ 작업한 내용

  • 홈페이지 마크업
  • 홈페이지 기능 구현

🌀 PR Point

  • 코드 수정 사항이나 개선 사항 생각나시는 거 있으시면 알려주세요!

🍰 참고사항

  • layout.tsx 에서 최소 높이, y방향 패딩, flex 관련 클래스를 제거했습니다. 높이나 flex 같은 부분은 각 페이지에서 처리해야 할 것 같아서 우선 제거했는데 다른 의견 있으시면 알려주세요! 환희님 담당 페이지들도 영향 없을지도 한번 확인 부탁드립니다 ㅎㅎ

📷 스크린샷 또는 GIF

2024-07-15.11.52.28.mov

@junseublim junseublim linked an issue Jul 15, 2024 that may be closed by this pull request
[FEATURE] 홈 페이지 #32
Closed
@junseublim junseublim self-assigned this Jul 15, 2024
hwanheejung
hwanheejung reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@hwanheejung hwanheejung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layout 바뀐대로 저도 페이지별로 수정할게요!
버튼 사이즈는 한 번 더 확인해보고 통일해야할 것 같습니다!
스크린샷 2024-07-16 오후 2 16 41

hwanheejung
hwanheejung approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@hwanheejung hwanheejung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@junseublim junseublim merged commit fbf0a4d into develop Jul 16, 2024
@junseublim junseublim deleted the feature/32 branch July 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwanheejung hwanheejung hwanheejung approved these changes

Assignees

@junseublim junseublim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] 홈 페이지
2 participants
@junseublim @hwanheejung