MARA-9 소셜로그인 기능 구현 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network Error
Network Error
choipureum
reviewed
Feb 8, 2024
|
|
||
| const redirectToLogin: () => Promise<void> = async () => { | ||
| if (!token) { | ||
| alert('로그인이 필요합니다.'); |
choipureum
reviewed
Feb 8, 2024
src/api/login/getToken.ts
Outdated
| localStorage.setItem('token', response.data.accessToken); | ||
| }) | ||
| .catch((error) => { | ||
| console.error(error); |
There was a problem hiding this comment.
[IMO]
query쓸거라 요기서 예외처리를 하기보다 query쪽에서 예외관리하는 것 어떨까요..!
지원되는 api들도 있고 Suspense 적용에도 이점이 있을 것같읍니당 🥰
There was a problem hiding this comment.
그리고 예외들은 로그 대신 토스트 나와도 좋을거 같읍니다아 디자이너랑 말씀해보시죠 이건
choipureum
reviewed
Feb 8, 2024
src/hooks/queries/useBaseQuery.ts
Outdated
| }; | ||
|
|
||
| export const useBaseQuery = <T>(queryKey: any, url: string) => { | ||
| return useQuery({ |
There was a problem hiding this comment.
query에서 onSuccess나 onError로 지원되는 api가 있지 않나용..!
choipureum
reviewed
Feb 8, 2024
| </Layout> | ||
| </ThemeProvider> | ||
| </RecoilRoot> | ||
| <QueryClientProvider client={queryClient}> |
There was a problem hiding this comment.
Suspense 써보는거 어떨까요 query 쓴김에 요고 서스펜스 있는 거로 알고있읍니다.
추가되면 더해서 에러바운더리나 fetching 시 사용될 스피너 or 스켈레톤 이라도 받는대로 추가되어야 될 것 같습니다..!
|
추가로 에러바운더리 빠른 이슈업 부탁드립니다🛠 |
hyeseon-han
approved these changes
Feb 8, 2024
added 3 commits
February 10, 2024 19:28
|
프로젝트 구조 통일로 일단 다른 수정 이전으로 머지하고 추후에 티켓 받아서 진행하겠습니다🥺🥺
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
이슈번호: Mara-9
작업내용
테스트 결과 또는 방법