Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Adds a watchlist to the redux-toolkit #82

Merged
merged 8 commits into from
Mar 5, 2022
Merged

[Feat] Adds a watchlist to the redux-toolkit #82

merged 8 commits into from
Mar 5, 2022

Conversation

BonhaengLee
Copy link
Member

@BonhaengLee BonhaengLee commented Mar 2, 2022 •
edited
Loading

๐Ÿ€ ๊ฐœ์š”

  • ๊ด€์‹ฌ๋ชฉ๋ก ๊ด€๋ จ ๋ฐ์ดํ„ฐ(watchlist) ๊ด€๋ฆฌ๋ฅผ reduxt-toolkit์œผ๋กœ ๋Œ€์ฒดํ•œ๋‹ค.
  • watchlist fetching ๋กœ์ง์„ AsyncThunk ํ•จ์ˆ˜๋กœ ๊ตฌํ˜„ํ•ด์„œ ๋น„๋™๊ธฐ ๋กœ์ง๊ณผ Store์™€ ์ธํ„ฐ๋ž™์…˜ํ•˜๋„๋ก ํ•ด์„œ ํ•ด๋‹น ๋กœ์ง์„ UI์™€ ๋ณ„๋„๋กœ ๋ถ„๋ฆฌ์‹œํ‚จ๋‹ค.

โœ๏ธ ์ž‘์—… ๋‚ด์šฉ

  • fetchWatchlist, watchlist, status, error ์ถ”๊ฐ€ ํ›„ useWatchlist() ๊ตฌํ˜„, ๊ธฐ์กด ์ปดํฌ๋„ŒํŠธ ๋‚ด์˜ fetching ๊ด€๋ จ ๋กœ์ง ๋ฆฌํŒฉํ„ฐ๋ง 81d2502
  • useWatchlist์˜ addWatchlist ๊ตฌํ˜„ 7aeedcd
  • useWatchlist์˜ deleteWatchlist ๊ตฌํ˜„ 2740ff8
  • useWatchlist์˜ checkWatchlistBySymbol ๊ตฌํ˜„ 83d45d2
  • StockList์—์„œ StockListItem ์ปดํฌ๋„ŒํŠธ ๋ถ„๋ฆฌ a99ed6f
  • ๋กœ๊ทธ์ธ ์‹œ ๊ด€์‹ฌ๋ชฉ๋ก ์ดˆ๊ธฐํ™” ๋ฐ ๋ถˆํ•„์š”ํ•œ ์ฃผ์„ ์ œ๊ฑฐ 1945599
  • Watchlist reducer ๋‹จ์œ„ ํ…Œ์ŠคํŠธ 76ae182

@BonhaengLee BonhaengLee self-assigned this Mar 2, 2022
@BonhaengLee BonhaengLee linked an issue Mar 2, 2022 that may be closed by this pull request
[Feat] watchlist with redux-toolkit #81
Closed
@BonhaengLee BonhaengLee force-pushed the feat/#81/watchlist-with-redux-toolkit branch from 84e5616 to 81d2502 Compare March 2, 2022 17:46
2heeesss
2heeesss approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@2heeesss 2heeesss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ๐Ÿ‘

@BonhaengLee BonhaengLee merged commit 8b6d856 into develop Mar 5, 2022
@2heeesss 2heeesss deleted the feat/#81/watchlist-with-redux-toolkit branch March 12, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2heeesss 2heeesss 2heeesss approved these changes

@chmini chmini Awaiting requested review from chmini

@Serzhul Serzhul Awaiting requested review from Serzhul

Assignees

@BonhaengLee BonhaengLee

Labels
enhancement ๐Ÿš€ New feature or request refactoring ๐Ÿ”ฉ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] watchlist with redux-toolkit
2 participants
@BonhaengLee @2heeesss