Skip to content

Commit

Permalink
feat: add support for additional env vars (#9)
Browse files Browse the repository at this point in the history
  • Loading branch information
m-yosefpor authored Aug 8, 2021
1 parent c753bd6 commit ff95876
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
4 changes: 2 additions & 2 deletions charts/alidns-webhook/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v1
appVersion: "0.2.0"
description: Deploys alidns webhook for cert-manager.
description: Deploys alidns webhook for cert-manager.
name: alidns-webhook
version: 0.4.0
version: 0.5.0
3 changes: 3 additions & 0 deletions charts/alidns-webhook/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ spec:
env:
- name: GROUP_NAME
value: {{ .Values.groupName | quote }}
{{- if .Values.env }}
{{- toYaml .Values.extraEnv | nindent 12 }}
{{- end }}
ports:
- name: https
containerPort: {{ .Values.securePort }}
Expand Down
4 changes: 2 additions & 2 deletions charts/alidns-webhook/templates/pki.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ metadata:
heritage: {{ .Release.Service }}
spec:
secretName: {{ include "alidns-webhook.rootCACertificate" . }}
duration: 43800h # 5y
duration: 43800h0m0s # 5y
issuerRef:
name: {{ include "alidns-webhook.selfSignedIssuer" . }}
commonName: "ca.alidns-webhook.cert-manager"
Expand Down Expand Up @@ -67,7 +67,7 @@ metadata:
heritage: {{ .Release.Service }}
spec:
secretName: {{ include "alidns-webhook.servingCertificate" . }}
duration: 8760h # 1y
duration: 8760h0m0s # 1y
issuerRef:
name: {{ include "alidns-webhook.rootCAIssuer" . }}
dnsNames:
Expand Down
8 changes: 8 additions & 0 deletions charts/alidns-webhook/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,11 @@ nodeSelector: {}
tolerations: []

affinity: {}


# Optional additional envs for the webhook container
extraEnv: []
# - name: ALIDNS_WEBHOOK_ENV_VAR_1
# value: "env_var_1"
# - name: ALIDNS_WEBHOOK_ENV_VAR_2
# value: "env_var_2"

0 comments on commit ff95876

Please sign in to comment.