Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM Incoming emails integration #725

Merged
merged 43 commits into from
Jan 7, 2022
Merged

CM Incoming emails integration #725

merged 43 commits into from
Jan 7, 2022

Conversation

ryantk
Copy link
Contributor

@ryantk ryantk commented Dec 20, 2021 •
edited
Loading

Changes in this PR

Tickets contained within:

Screenshots of UI changes

Screenshot 2021-12-30 at 15 51 21

Screenshot 2021-12-31 at 11 31 42

@viezly
Copy link

viezly bot commented Dec 20, 2021 •
edited
Loading

This pull request is split into 8 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • /
  • app
  • app/views
  • config
  • db
  • lib
  • lib/microsoft_graph
  • spec/factories/support
  • spec/features/support/emails
  • spec/lib

@ryantk ryantk temporarily deployed to preview December 20, 2021 15:18 Inactive
@ryantk ryantk temporarily deployed to preview December 20, 2021 15:24 Inactive
@ryantk ryantk temporarily deployed to preview December 20, 2021 15:39 Inactive
@ryantk ryantk temporarily deployed to preview December 20, 2021 16:02 Inactive
@ryantk ryantk temporarily deployed to preview December 20, 2021 16:25 Inactive
@ryantk ryantk temporarily deployed to preview December 31, 2021 12:15 Inactive
@ryantk ryantk changed the title WIP: CM Incoming emails integration CM Incoming emails integration Jan 4, 2022
@ryantk ryantk marked this pull request as ready for review January 4, 2022 09:51
@ryantk ryantk requested a review from AndrewCowle January 4, 2022 10:16
@ryantk
Copy link
Contributor Author

ryantk commented Jan 4, 2022

@AndrewCowle I appreciate this is quite large but its everything I've done over Xmas. I can talk you through it if you want but it might be good to pull the code and have a play with the feature toggles etc as it would be good to get it into develop.

@ryantk
Copy link
Contributor Author

ryantk commented Jan 5, 2022

#26 Case worker can see a list of emails separately to the cases

@PiperS52 PiperS52 self-requested a review January 7, 2022 11:39
@ryantk ryantk requested a review from EdwinKruglov January 7, 2022 11:41
PiperS52
PiperS52 approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@PiperS52 PiperS52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pulled down and runs as expected, with bug addressed regarding first case link when switching off feature.

@ryantk ryantk merged commit 5fa5428 into develop Jan 7, 2022
@ryantk ryantk deleted the incoming-emails branch January 7, 2022 13:04
@ryantk
Copy link
Contributor Author

ryantk commented Jan 7, 2022

#26 Case worker can see the case that an email is auto linked to as part of the email view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiperS52 PiperS52 PiperS52 approved these changes

@EdwinKruglov EdwinKruglov EdwinKruglov approved these changes

@AndrewCowle AndrewCowle Awaiting requested review from AndrewCowle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryantk @EdwinKruglov @PiperS52