Transaction rollback behaviour bug #173
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asatwal
force-pushed
the
main
branch
2 times, most recently
from
75d06fb to
a4dcb2d
Compare
While investigating an issue of missing data we started investigating the implementation of sending events while inside Rails transactions. This commit reproduces a bug that may be contributing to some of our data issues. The existing spec assets that no events are send if the transaction is rolled back, however the spec was passing due to `allowlist_fields` not being set. After setting the `allowlist_fields` we see a test failure as the `SendEvents` job is called.
asatwal
force-pushed
the
bug-rollback-behaviour
branch
from
05efa13 to
f34c9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating an issue of missing data we started investigating the implementation of sending events while inside Rails transactions.
This PR reproduces a bug that may be contributing to some of the data issues in the Apply & Manage service.
The existing spec asserts that no events are sent if the transaction is rolled back, however the spec was passing due to
allowlist_fieldsnot being set.After setting the
allowlist_fieldswe see a test failure as theSendEventsjob is called.We have traced the origins of our data issue back to the introduction of #158