Fix WIF api call options #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asatwal
force-pushed
the
fix-wif-api-call-options
branch
from
2b683a1 to
848bed7
Compare
goodviber
approved these changes
Nov 25, 2024
asatwal
added a commit
that referenced
this pull request
Nov 25, 2024
* Fix retry options to Google API calls that are causing errors in GIT * Cater for the max elapsed retry durection for all retries in the token expiry leeway * Fix syntax used for enabling/disabling cop Style/ClassVars * Fix out of date Gemfile.lock * Hold durations as integers in constants to avoid use of ActiveSupport * Fix events_client test stub for WIF
asatwal
added a commit
that referenced
this pull request
Nov 26, 2024
* Fix retry options to Google API calls that are causing errors in GIT * Cater for the max elapsed retry durection for all retries in the token expiry leeway * Fix syntax used for enabling/disabling cop Style/ClassVars * Fix out of date Gemfile.lock * Hold durations as integers in constants to avoid use of ActiveSupport * Fix events_client test stub for WIF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Ticket
The initialisation of options to Google API WIF calls is causing errors on GIT.
Currently this line:
Google::Apis::RequestOptions.new(retries: 3)Causes the following errors in the options:
This error has been fixed in the PR and the authorization also setup properly