Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think this should fix multi-comments noise #1281

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Conversation

kicferk1
Copy link
Contributor

Ticket and context

Our github actions bot just keeps commenting. I think unsplash/comment-on-pr#44 is what made it fail for us. In particular

if !duplicate_msg_pattern.empty? || !delete_prev_regex_msg.empty?

is a guard for any duplication checks. I hope providing a pattern will fix our issues.

@kicferk1 kicferk1 changed the title I think this should fix multi-comments I think this should fix multi-comments noise Oct 18, 2021
@github-actions
Copy link

Created review app at https://ecf-review-pr-1281.london.cloudapps.digital

@github-actions
Copy link

Smoke tests passed against the review app.

@kicferk1 kicferk1 merged commit 1a9c48d into develop Oct 18, 2021
@kicferk1 kicferk1 deleted the reduce-comment-spam branch October 18, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants