Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin version of comment-on-pr #1586

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Conversation

FriedSock
Copy link
Contributor

@FriedSock FriedSock commented Jan 6, 2022

The builds started failing with a weird error coming from this package when it tries to comment that a review app has been deployed. Attempt to go back to the previous version rather than master

unsplash/comment-on-pr#51

Ticket and context

Ticket:

Tech review

Is there anything that the code reviewer should know?

Code quality checks

  • All commit messages are meaningful and true
  • Added enough automated tests

HTML Checks

  • All new pages have automated accessibility checks
  • All new pages have visual tests via Percy

Gotchas

  • All School queries are correctly scoped - eligible when they need to be

Product review

How can someone see it it review app?

  1. Click the link to review app (posted by a github-actions bot below)
  2. Follow the steps from the ticket.

External API changes

Does this change anything in our external APIs? If so, did you remember to update the CHANGELOG for Lead Providers? (docs/source/release-notes)

The builds started failing with a weird error coming from this package when it tries to comment that a review app has been deployed. Attempt to go back to the previous version rather than master
@FriedSock FriedSock enabled auto-merge January 6, 2022 13:57
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Created review app at https://ecf-review-pr-1586.london.cloudapps.digital

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Smoke tests passed against the review app.

@FriedSock FriedSock merged commit c89268c into develop Jan 6, 2022
@FriedSock FriedSock deleted the pin-verison-of-comment-on-pr branch January 6, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants