Fix GitHub codespaces #5378
Merged
Fix GitHub codespaces #5378
+60
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to bring it inline with NPQ registration codespace configuration, as this contains various fixes to get codespaces to run and the applications are very similar. Notable fixes: - Expose Postgres on the correct/default port - Setup Postgres user for `vscode` - Manually switch bundler version prior to `bundle install` - Build API guidance as part of `boot.sh` - Disable CSRF protection (for some reason it doesn't work in codespaces) - Boot the app with foreman so we get JS/CSS watching
|
Review app deployed to https://cpd-ecf-review-5378-web.test.teacherservices.cloud |
leandroalemao
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
@ethax-ross Tested here and looks like it's working well. 👏 tks
mooktakim
approved these changes
Dec 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-3847
Context
The GitHub codespace for ECF is not building/running. We want to fix it so that we content editors can use it to make changes easily.
Changes proposed in this pull request
Update to bring it inline with NPQ registration codespace configuration, as this contains various fixes to get codespaces to run and the applications are very similar. Notable fixes:
vscodebundle installboot.shGuidance to review
Switch to the branch in GitHub and boot up a new codespace, check that: