Spike: mentor declarations using STI #5385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethax-ross
force-pushed
the
3831-mentor-declarations-sti
branch
from
63c52e0 to
13f8321
Compare
|
Review app deployed to https://cpd-ecf-review-5385-web.test.teacherservices.cloud |
Update factories to create correct mentor/ect declarations. Update calculators and reports to only include ECT declarations (as mentor declarations will be on a separate calculator).
ethax-ross
force-pushed
the
3831-mentor-declarations-sti
branch
from
13f8321 to
ecd8bd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spike to look into the necessary changes to implement the notion of 'mentor declarations' using the existing STI modelling.