[CPDLP-3843] Remove token access for NPQ (NPQ Post Separation Cleanup) #5386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://cpd-ecf-review-5386-web.test.teacherservices.cloud |
leandroalemao
force-pushed
the
CPDLP-3843
branch
from
e532d0f to
f46ca28
Compare
cwrw
reviewed
Dec 19, 2024
| @@ -50,6 +50,6 @@ def check_access_scope | |||
| end | |||
|
|
|||
| def access_scope | |||
There was a problem hiding this comment.
having a look at controllers like DataStudio::SchoolRolloutController these have:
def access_scope
ApiToken.where(private_api_access: true)
end
Which we want to keep. Can we keep this as is and keep the level the same everywhere and just remove the NPQ access please instead?
leandroalemao
force-pushed
the
CPDLP-3843
branch
2 times, most recently
from
10442a2 to
f761ecc
Compare
cwrw
reviewed
Dec 20, 2024
| @@ -238,15 +238,11 @@ | |||
| # The tokens below have different unhashed version to avoid worrying about clever cryptographic attacks | |||
| if Rails.env.review? | |||
| EngageAndLearnApiToken.find_or_create_by!(hashed_token: "dfce9a34c6f982e8adb4b903f8b6064682e6ad1f7858c41ed8a0a7468abc8896") | |||
| NPQRegistrationApiToken.find_or_create_by!(hashed_token: "1dae3836ed90df4b796eff1f4a4713247ac5bc8a00352ea46eee621d74cd4fcf") | |||
There was a problem hiding this comment.
maybe we can also delete NPQRegistrationApiToken class as well? let me know what you think
leandroalemao
force-pushed
the
CPDLP-3843
branch
from
f761ecc to
814e24c
Compare
cwrw
approved these changes
Dec 20, 2024
mooktakim
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Now we’ve removed all the data we need to remove access to NPQ tokens in ECF in the API.
Changes proposed in this pull request
Remove the NPQ API token setup from the ECF API.