update page title, now responsive to article title and correctly ends… #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created review web app at https://eyfs-review-pr-537.london.cloudapps.digital and cms app https://eyfs-cms-review-pr-537.london.cloudapps.digital |
ebrett
approved these changes
Jan 7, 2022
ebrett
pushed a commit
that referenced
this pull request
Jan 11, 2022
ebrett
added a commit
that referenced
this pull request
Jan 27, 2022
* remove conditional so Articles link always displays (#527) Co-authored-by: Adam Goldstone <adam.goldstone@education.gov.uk> * v1.3.1 causes failure so downgrading to v1.3.0 (#533) see unsplash/comment-on-pr#51 * update page title, now responsive to article title and correctly ends with "GOV.UK" (#537) * change deletion notice to accepted wording (#539) * Hfeyp 597 remove back button on edit page screen (#530) * remove back button from edit page screen * update syntax to newer form of key value assignment, move class assignment outside data assignment * changed behaviour so clicking cancel returns to previous screen * Add space to end of hash Co-authored-by: Rob Nichols <reggieb@users.noreply.github.com> Co-authored-by: Rob Nichols <reggieb@users.noreply.github.com> * Move sentry configuration file to initializers to ensure it is loaded on app start (#546) * Update of gems (#548) * aws-sdk-s3 * devise-security * rails gems to 6.1.4.4 actioncable actionmailbox actionmailer actionpack actiontext actionview activejob activemodel activerecord activestorage activesupport railsties * govspeak * Update tracking id for preprod to use new value (#547) * remove other useful resources section (#542) * remove other useful resources section * add newline at end of file * HFEYP-623 change from flexbox to grid so last line of grid aligns left (#545) * change from flexbox to grid so last line of grid aligns left * change column width to correct calculation * add gem-c-govspeak class to articles (#532) * add gem-c-govspeak class to articles * move gem-c-govspeak class to govuk-body, add to article preview * HFEYP-626 Adds alt text to article feature image with helper (#538) * Add feature image helper to properly format images for articles Added proper styling to the admin preview page, which was missing * Include thumbnail images on index page * Add guard to helper * Use alt text for title attribute * Cms refactor (#506) * refactor content blocks into admin namespace * WIP: refactor content assets into admin namespace * refactor content blocks into admin namespace * remove commented out code * refactor contentPage & versions to admin namespace * minor changes to back button positions * fix rubocop issues * refactor specs * refactor specs * delete routing specs * fix typo * add 404 redirect * refactor feature specs for admin paths * refactor request specs for admin path * refactor view specs for admin paths * refactor for admin path * correct path * add description * fix syntax errors * fix content_pages rspec * remove unnecessary comments * HFEYP-651 Update javascript packages and listen gem (#551) * Update using `yarn upgrade --latest` * Update listen gem * Upgrade using bundle update * Preprod uses staging credentials, not production (#553) * HFEYP-652 remove duplicate spec (#554) * remove duplicate and flaky spec * remove empty spec * Updated with suggestion to remove unused class (#555) Still some concern with the issue that Youtube snippets will not go go through the sanitize method * HFEYP-604 Update styles for contents list (#550) * Add styling from govuk_publishing_component * Move contents list style within govspeak * Revert to using the margins on li elements * add target _blank to open in new tab (#567) * Hfeyp 612 preview labels (#560) * add preview of live to controller and route * add preview label to draft preview page * update links to preview of live page * update preview of live page link * add preview of live page * add preview live spec * correct id * correct path * move to one line * add newline * remove creation of new copy of content page * add aria labels for context Co-authored-by: Brett McHargue <ebrett@users.noreply.github.com> * Hfeyp 199 editor sign in page update (#571) * change header text * change label classes so now smaller text * move line break inside conditional, remove unnecessary line break * change call to action wording Co-authored-by: Brett McHargue <ebrett@users.noreply.github.com> * HFEYP 36 CMS - Change Log out to take user to sign in page (#572) * change sign out redirect to page that user was previously on * add rubocop suggestions * - update failing specs with new behaviour - remove duplicate specs Co-authored-by: Brett McHargue <ebrett@users.noreply.github.com> * Use main as integration branch, rather than develop (#575) * Update gems and packages (#577) Co-authored-by: Adam Goldstone <13471320+agoldstone93@users.noreply.github.com> Co-authored-by: Adam Goldstone <adam.goldstone@education.gov.uk> Co-authored-by: Rob Nichols <reggieb@users.noreply.github.com> Co-authored-by: tunde-anddigital <50167725+tunde-anddigital@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… with "GOV.UK"
Ticket and context
Ticket: HFEYP-631
Tech review
Updated page title of articles to now display "[Article title] - Help for early years providers - GOV.UK"
Code quality checks
Product review
How can someone see it in review app?