Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SASS support to Vite app and restructured styles imports #1821

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

WolfyUK
Copy link
Collaborator

@WolfyUK WolfyUK commented Jan 29, 2025

Context

AB#247410 AB#247409

Change proposed in this pull request

Replaced the single index.css with multiple styles.scss files alongside each dependent component in Vite folder convention. Re-used govuk-frontend variables and mixins where available, rather than duplicate the effort.

Guidance to review

Source maps could not be generated from the SASS at this time. Otherwise, validate in the Vite dev server and/or a prod build-and-copy to Web from front-end after first updating npm dependencies.

Checklist (add/remove as appropriate)

  • Work items have been linked (use AB#)
  • Your code builds clean without any errors or warnings
  • You have run all unit/integration tests and they pass
  • Your branch has been rebased onto main
  • You have tested by running locally
  • You have reviewed with UX/Design

@WolfyUK WolfyUK force-pushed the tech-debt/247410/stylesheets branch 2 times, most recently from d67f740 to e000f71 Compare February 3, 2025 10:10
@WolfyUK WolfyUK force-pushed the tech-debt/247410/stylesheets branch from e000f71 to 63e91d8 Compare February 6, 2025 14:54
@WolfyUK WolfyUK marked this pull request as ready for review February 7, 2025 09:38
@J05h-L J05h-L self-requested a review February 7, 2025 10:01
@WolfyUK WolfyUK merged commit c3de7bf into main Feb 7, 2025
16 checks passed
@WolfyUK WolfyUK deleted the tech-debt/247410/stylesheets branch February 7, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants