New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clawback table columns #1259

Open

dp-daly wants to merge 3 commits into main from dpd/update-clawback-table-columns

+22 −12

Contributor

dp-daly commented Dec 20, 2024 •

edited

Loading

Context

Content and design changes mean that we need to update the way we model our data for clawbacks.

Changes proposed in this pull request

Remove hours_rejected column from mentor_trainings table
Add hours_clawed_back column to mentor_trainings table
Add reason_clawed_back to column mentor_trainings table
Remove hours_rejected validation from Claims::MentorTraining model

Guidance to review

Review the migration file.
Run mentor_trainings validation tests.

Link to Trello card

https://trello.com/c/yxlrHhAt/1017-clawbacks-update-clawback-table-columns

dp-daly added 3 commits

December 20, 2024 14:26


          Set 'hours_rejected' column to be ignored in mentor_trainings table

dca67b9


          Run migration and remove ignored_columns line from mentor_trainings file

7fcabdb


          Rollback migration and rerun using change_table block with bulk -> true

8771f51

dp-daly requested review from a team as code owners

December 20, 2024 16:24

dp-daly self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet