Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create sampling send and deliver #1269

Merged
merged 10 commits into from
Dec 24, 2024
Merged

Create sampling send and deliver #1269

merged 10 commits into from
Dec 24, 2024

Conversation

Kizr
Copy link
Contributor

@Kizr Kizr commented Dec 24, 2024 •
edited
Loading

Context

Now that all of the individual functionality of the sampling flow have been implemented we needed to tie them all together so that the correct processes happen after a support user has uploaded the sampling CSV.

Changes proposed in this pull request

  • Adds the CreateAndDeliver service to group the logic together
  • Adds the CreateAndDeliverJob to call the CreateAndDeliver service asynchronously
  • Adds the provider views for downloading their CSV containing the claims that require checking
  • Adds a GenerateCSVFile service that creates the provider CSV
  • Alters the upload wizard to accept current user
  • Adds some useful delegations to the provider sampling model.

Guidance to review

  • Log in as Colin
  • Upload a CSV for claims that need to be sampled
  • Check the email that has been sent to the provider
  • Click on the download link
  • Verify the CSV is correct

Link to Trello card

[Sampling] Create CreateAndDeliver service

@Kizr Kizr requested a review from a team as a code owner December 24, 2024 10:27
@Kizr Kizr self-assigned this Dec 24, 2024
@Kizr Kizr added the deploy A Review App will be created for PRs with this label label Dec 24, 2024
@Kizr Kizr force-pushed the ba/create-sampling-send-and-deliver branch from b321e50 to 6375577 Compare December 24, 2024 10:32
@Kizr Kizr force-pushed the ba/create-sampling-send-and-deliver branch from 6375577 to 1733a66 Compare December 24, 2024 10:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

Review app track and pay deployed to https://track-and-pay-1269.test.teacherservices.cloud was deleted
Review app school placements deployed to https://manage-school-placements-1269.test.teacherservices.cloud was deleted

JamieCleare2525
JamieCleare2525 reviewed Dec 24, 2024
View reviewed changes
Copy link
Contributor

@JamieCleare2525 JamieCleare2525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of missed page_title elements

@Kizr Kizr merged commit eed6a4f into main Dec 24, 2024
8 checks passed
@Kizr Kizr deleted the ba/create-sampling-send-and-deliver branch December 24, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieCleare2525 JamieCleare2525 JamieCleare2525 approved these changes

Assignees

@Kizr Kizr

Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kizr @JamieCleare2525