Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception and conditionally protect keys with KV #1241

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Remove exception and conditionally protect keys with KV #1241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Dfe.PrepareConversions/Dfe.PrepareConversions/Utils/DataProtectionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,15 @@ public static void AddDataProtectionService(this IServiceCollection services, IC
var dpTargetPath = "@/srv/app/storage";

if (Directory.Exists(dpTargetPath)) {
dp.PersistKeysToFileSystem(new DirectoryInfo(dpTargetPath));

// If a Key Vault Key URI is defined, expect to encrypt the keys.xml
string kvProtectionKeyUri = configuration.GetValue<string>("DataProtection:KeyVaultKey");

if (!string.IsNullOrWhiteSpace(kvProtectionKeyUri))
{
throw new InvalidOperationException("DataProtection:Path is undefined or empty");
dp.ProtectKeysWithAzureKeyVault(new Uri(kvProtectionKeyUri), new DefaultAzureCredential());
}

dp.PersistKeysToFileSystem(new DirectoryInfo(dpTargetPath));
dp.ProtectKeysWithAzureKeyVault(new Uri(kvProtectionKeyUri), new DefaultAzureCredential());
}
}
}
Expand Down
Loading