-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpecFlow structure added and initial accessibility test created #17
Conversation
Dfe.Data.SearchPrototype/Web/Tests/Acceptance/Steps/AccessibilitySteps.cs
Outdated
Show resolved
Hide resolved
moved page object dir out to root of project added appsettings test file
Dfe.Data.SearchPrototype/Web/Tests/PageObjectModel/Setup/DocumentObjectModelExtractor.cs
Outdated
Show resolved
Hide resolved
Dfe.Data.SearchPrototype/Web/Tests/PageObjectModel/PrivacyPage.cs
Outdated
Show resolved
Hide resolved
So, we have an IWebDriverContext with Selenium which is the thing that gives us access to the page-level DOM. So I think what we need to do is to create an IDocumentObjectModel extractor that we can inject into the given page objects (i.e. HomePage etc) and the underlying implementation we care about is something we can wire-up at runtime. That way we can create a unified page object model but leave the details as to how we extract the DOM to the underlying infrastructure (be it Selenium, AngleSharp, or whatever). This way we don't have to bleed Selenium concerns (using Be) or AngleSharp concerns at the page object level. We can have a get-together to discuss when everyone is back. :) |
Build will fail after the recent push on 23/07/24 - will fix on 25/07/2024. |
removed privacy page
This test PR build will fail until the search changes are merged into main; likely next week. |
Dfe.Data.SearchPrototype/Web/Tests/PageIntegrationTests/SearchPageTests.cs
Show resolved
Hide resolved
Build will fail with single accessibility violation on search results page which will be resolved in one of the next PRs. |
Dfe.Data.SearchPrototype/Web/Tests/AcceptanceTests/Drivers/WebDriverFactory.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work to be completed in a later PR - Fix for web host to stop host server being restarted for each test
Overview
This PR adds SpecFlow to the
Web.Tests
project along with an initial accessibility test on the homepage.Major changes
Axe Core
,Fluent Assertions
,Selenium WebDriver Chrome
, andSpecFlow
packages added toWeb.Test
.Drivers
directory containing classes for the control and config of Selenium WebDriver.Features
directory with respectiveAccessbilityTests.feature
file containing accessibility scenario and test steps.Steps
directory with respectiveAccessibilitySteps.cs
step definition file containing code for test steps.Hooks
directory with respectiveSpecFlowHooks.cs
for setting up and tearing down the web app and the WebDriver.Options
directory containing options classes for WebDriver and Axe.DummySearchServiceAdapter
added along withEstablishments.json
file for providing test data through theweb
establishment search.build.yml
updated torun-on: windows-latest
to be able to run Selenium.ToDo
Next round of work to include the following:
SpecFlowHooks.cs
.Add Selenium options including running inHeadless
et al.AddAccessibilityOptions.cs
as per SD test project.Add logging of accessibility test to output file.