Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten ACLs for Key Vault network rules #13

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Tighten ACLs for Key Vault network rules #13

merged 1 commit into from
Apr 13, 2023

Conversation

DrizzlyOwl
Copy link
Collaborator

@DrizzlyOwl DrizzlyOwl commented Apr 12, 2023 •
edited
Loading

This PR tightens up the security of the TF Vars Key Vault by requiring a list of trusted IPv4 addresses

# List of IPV4 Addresses that are permitted to access the Key Vault
key_vault_access_ipv4 = [
  "x.x.x.x"
]

Additionally, it will now also support including a list of authorised Subnet IDs where resources may need to connect to Key Vault

@DrizzlyOwl DrizzlyOwl requested a review from Stretch96 April 12, 2023 15:08
@DrizzlyOwl DrizzlyOwl enabled auto-merge April 13, 2023 09:27
Stretch96
Stretch96 requested changes Apr 13, 2023
View reviewed changes
locals.tf Outdated Show resolved Hide resolved
@DrizzlyOwl DrizzlyOwl requested a review from Stretch96 April 13, 2023 15:19
@DrizzlyOwl DrizzlyOwl merged commit d6ada6f into main Apr 13, 2023
@DrizzlyOwl DrizzlyOwl deleted the key-vault-acls branch April 13, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stretch96 Stretch96 Stretch96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrizzlyOwl @Stretch96