Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[680] Front door redirect rules #72

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Nov 1, 2023

Context

Create front door redirects so websites can easily be migrated

Changes proposed in this pull request

Allow passing a list of redirect rules per environment. Rules are triggered per domain and may:

  • redirect to domain on the same front door or external
  • redirect to the same path as in the incoming request
  • redirect to a specific path
  • add a query string

Additional rule sets may still be passed using the rule_set_ids variable

Guidance to review

Tested with get an adviser: DFE-Digital/get-teacher-training-adviser-service#1398

After merge

Update DFE-Digital/get-teacher-training-adviser-service#1398

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti saliceti added the devops label Nov 1, 2023
@saliceti saliceti force-pushed the 680-add-redirect-to-aks-environment-domain-module branch from 8bc14a7 to 416aeb3 Compare November 1, 2023 19:40
Allow passing a list of redirect rules per environment. Rules are
triggered per domain and may:
- redirect to domain on the same front door or external
- redirect to the same path as in the incoming request
- redirect to a specific path
- add a query string

Additional rule sets may still be passed using the rule_set_ids variable
@saliceti saliceti force-pushed the 680-add-redirect-to-aks-environment-domain-module branch from 416aeb3 to 334347a Compare November 1, 2023 19:41
@saliceti
Copy link
Member Author

saliceti commented Nov 1, 2023

@saliceti saliceti merged commit 4d19aa6 into main Nov 2, 2023
3 checks passed
@saliceti saliceti deleted the 680-add-redirect-to-aks-environment-domain-module branch November 2, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants