Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix markdownlint pre-commit checks #365

Merged
merged 6 commits into from
Jan 16, 2024
Merged

fix markdownlint pre-commit checks #365

merged 6 commits into from
Jan 16, 2024

Conversation

jarkenau
Copy link
Member

@jarkenau jarkenau commented Jan 8, 2024

This PR includes:

  • Fixes the markdownlint pre-commit checks caused by a deprecating warning in non-LTS version of Node.js.
  • Remove ruby config files for the old linter (missed in Change markdown linter #362)
  • Update pre-commit check versions (via auto-update)
  • Additional configuration of the new markdown linter.

A deprecation warning in the downstream markdownlint package causes the pre-commit checks to fail.
The workaround is to use an LTS version of Node for running the checks, as deprecation warnings are not generated.

Related GitHub Issues:
- igorshubovych/markdownlint-cli#437
- DavidAnson/markdownlint#1032
@jarkenau jarkenau self-assigned this Jan 8, 2024
@jarkenau jarkenau force-pushed the fix-markdownlinter branch from 22cd1c9 to c8016bf Compare January 8, 2024 11:49
@jarkenau jarkenau merged commit 154b059 into main Jan 16, 2024
8 checks passed
@jarkenau jarkenau deleted the fix-markdownlinter branch January 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants