Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fisheye #18

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feature/fisheye #18

wants to merge 5 commits into from

Conversation

tik0
Copy link
Collaborator

@tik0 tik0 commented Jun 1, 2024

This PR adds two new lens types FISHEYE_EQUIDISTANT and FISHEYE_EQUISOLID for the camera as described in blender's fisheye manual. The default camera is still the PERSPECTIVE camera such that the current behavior of syclops is not affected. This PR may still miss some tweaks:

  • Output of RGB images is still in RECT folders, which does not make any sense for fisheye images
  • frustum feature is currently not supported for fisheye
  • intrinsic camera matrix is set to 1 as a quick workaround
  • documentation missing

Example
Using the following parameters creates an image as follows

sensor:
  syclops_sensor_camera:
    - name: main_camera_cabin_front
      frame_id: main_camera_link_cabin_front
      lense_type: FISHEYE_EQUISOLID
      resolution: [1920, 1536]
      focal_length: 1.915301618 # mm
      fisheye_fov: 3.4 # rad i.e., 195 deg
      sensor_width: 5.76 # 7.45 mm diagonal (type 1/2.42")
      # ...

image

tik0 added 2 commits June 1, 2024 01:18
Signed-off-by: Timo Korthals <timo.korthals@claas.com>
Signed-off-by: Timo Korthals <timo.korthals@claas.com>
@tik0 tik0 added the enhancement New feature or request label Jun 1, 2024
@tik0 tik0 requested a review from aelmiger June 1, 2024 00:15
@tik0 tik0 self-assigned this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants