-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use redis pipeline to write CopyToString #46
base: unstable
Are you sure you want to change the base?
use redis pipeline to write CopyToString #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. Can you replicate pipelining for lists and hashes as well? Also, please run the tests w/ 50k rows or more (this is more realistic), with Postgres as well if possible. Want to experiment with Redis transactions after pipeline implementation too.
Should we replicate the pipelining for lists and hashes? I think we could try to exec the pipeline after it reads through all the rows rather than just column. |
I made the pipeline executed after we scanned through all rows rather than just columns. pipeline executed after column scan (10k rows)
pipeline executed after row scan (10k rows)
pipeline executed after column scan (50k rows)
pipeline executed after row scan (50k rows)
haven't test on postgres yet, will update you later |
Agreed. Yeah, bulk insertion into Redis is better overall (IMO we should do pipelining for all datatypes). Try to implement it similarly across all data types and optimize it accordingly if possible. Really great contributions so far 👍🏻. The goal all in all is <5 seconds per function for 1million+ rows. Please join the Discord so that we can communicate more efficiently, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, but I prefer @cappe987's solution, so most likely going to merge it. I will approve and add the tag so that this PR is counted in your hacktoberfest profile (I won't close). Let me know if you have any questions, thanks.
To solve issue #45
before data pipelining
after data pipelining