fix announcement start time #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lightczx
approved these changes
Apr 23, 2024
| @@ -2922,13 +2922,19 @@ | |||
| <value>Weapon WIKI</value> | |||
| </data> | |||
| <data name="WebAnnouncementMatchPermanentActivityTime" xml:space="preserve"> | |||
| <value>(?:〓Event Duration〓|〓Quest Start Time〓).*?\d\.\dthe Version update(?:after|)Permanently available</value> | |||
| <value>(?:〓Event Duration〓|〓Quest Start Time〓).*?Permanently.*?Version.*?(\d\.\d).*?update</value> | |||
qhy040404
requested changes
Apr 23, 2024
src/Snap.Hutao/Snap.Hutao/Service/Announcement/AnnouncementService.cs
Outdated
Show resolved
Hide resolved
qhy040404
approved these changes
Apr 23, 2024
qhy040404
requested changes
Apr 23, 2024
Comment on lines
116
to
130
| WebAnnouncement? versionUpdate = announcementListWrappers | ||
| .Single(wrapper => wrapper.TypeId == 2) | ||
| .List | ||
| .Single(ann => AnnouncementRegex.VersionUpdateTitleRegex.IsMatch(ann.Title)); | ||
| .SingleOrDefault(ann => AnnouncementRegex.VersionUpdateTitleRegex.IsMatch(ann.Title)); | ||
|
|
||
| if (AnnouncementRegex.VersionUpdateTimeRegex.Match(versionUpdate.Content) is not { Success: true } versionUpdateMatch) | ||
| if (versionUpdate is not null) | ||
| { | ||
| return; | ||
| } | ||
| if (AnnouncementRegex.VersionUpdateTimeRegex.Match(versionUpdate.Content) is not { Success: true } versionUpdateMatch) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| DateTimeOffset versionUpdateTime = UnsafeDateTimeOffset.ParseDateTime(versionUpdateMatch.Groups[1].ValueSpan, offset); | ||
| versionStartTimeDict.Add(VersionRegex().Match(versionUpdate.Title).Groups[1].Value, versionUpdateTime); | ||
| DateTimeOffset versionUpdateTime = UnsafeDateTimeOffset.ParseDateTime(versionUpdateMatch.Groups[1].ValueSpan, offset); | ||
| versionStartTimeDict.Add(VersionRegex().Match(versionUpdate.Title).Groups[1].Value, versionUpdateTime); | ||
| } |
There was a problem hiding this comment.
正则式本地化好像有问题，韩语的公告就显示不出来
There was a problem hiding this comment.
这个通过修改正则来修复，不然出来的时间也是错的，不显示在这里是intended
There was a problem hiding this comment.
所以判断一下，这样最多只是显示的时间错了，不会出现没有公告的情况
There was a problem hiding this comment.
对于活动公告的准确性来说，我个人认为不太能接受
看其他reviewer吧
|
Hi @Natrium0521 感谢你对本项目的贡献，为了方便后续的交流你可以加入我们的开发交流群 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
修复了在版本更新维护预告发布后，版本更新说明发布前，活动公告显示的开始时间错误的问题：
修改了部分语言提取公告时间的正则表达式。
Related Issue
Checklist
developbranch