Skip to content

Commit

Permalink
feat: SD will always bundle proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
fstagni committed Sep 12, 2024
1 parent 83219e3 commit 201cde4
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Let's take an example::
maxCPUTime = 200
MaxTotalJobs = 5
MaxWaitingJobs = 10
BundleProxy = True
RemoveOutput = True
}
# This queue has Tag = GPU. So it will accept:
Expand Down
1 change: 0 additions & 1 deletion docs/source/AdministratorGuide/Tutorials/installWMS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ Then, as ``diracuser`` with the ``dirac_admin`` proxy, we need to define a CE in
CPUTime = 40000
MaxTotalJobs = 5
MaxWaitingJobs = 10
BundleProxy = True
BatchError = /home/diracpilot/localsite/error
ExecutableArea = /home/diracpilot/localsite/submission
RemoveOutput = True
Expand Down
11 changes: 3 additions & 8 deletions src/DIRAC/WorkloadManagementSystem/Agent/SiteDirector.py
Original file line number Diff line number Diff line change
Expand Up @@ -730,16 +730,11 @@ def _submitPilotsToQueue(self, pilotsToSubmit, ce, queue):
:rtype: dict
"""
self.log.info("Going to submit pilots", f"(a maximum of {pilotsToSubmit} pilots to {queue} queue)")

bundleProxy = self.queueDict[queue].get("BundleProxy", False)
proxy = None
if bundleProxy:
proxy = ce.proxy


jobExecDir = self.queueDict[queue]["ParametersDict"].get("JobExecDir", "")
envVariables = self.queueDict[queue]["ParametersDict"].get("EnvironmentVariables", None)

executable = self.getExecutable(queue, proxy=proxy, jobExecDir=jobExecDir, envVariables=envVariables)
executable = self.getExecutable(queue, proxy=ce.proxy, jobExecDir=jobExecDir, envVariables=envVariables)

submitResult = ce.submitJob(executable, "", pilotsToSubmit)
# In case the CE does not need the executable after the submission, we delete it
Expand Down Expand Up @@ -956,7 +951,7 @@ def getExecutable(self, queue, proxy=None, jobExecDir="", envVariables=None, **k
"""Prepare the full executable for queue
:param str queue: queue name
:param bool proxy: flag that say if to bundle or not the proxy
:param str proxy: proxy to bundle
:param str jobExecDir: pilot execution dir (normally an empty string)
:returns: a string the options for the pilot
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ def getQueuesResolved(
if checkPlatform:
setPlatform(ceDict, queueDict[queueName]["ParametersDict"])

bundleProxy = queueDict[queueName]["ParametersDict"].get("BundleProxy", ceDict.get("BundleProxy"))
if bundleProxy and bundleProxy.lower() in ["true", "yes", "1"]:
queueDict[queueName]["BundleProxy"] = True

return S_OK(queueDict)


Expand Down

0 comments on commit 201cde4

Please sign in to comment.