Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] print a warning message when no CFG file is found #6945

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Mar 29, 2023

BEGINRELEASENOTES

*Core
FIX: print a warning message when no CFG file is found

ENDRELEASENOTES

This is for PR #6772.

@fstagni fstagni requested a review from atsareg as a code owner March 29, 2023 10:33
@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Mar 29, 2023
Lorenzov1999
Lorenzov1999 previously approved these changes Mar 29, 2023
@chaen
Copy link
Contributor

chaen commented Mar 29, 2023

I actually moved from warn to debug here, because it is basically always written
64cd562

So we should probably come up with something more clever. Like, printing a warning if no config file whatsoever is given (default, CLI, and env variabe)

@atsareg
Copy link
Contributor

atsareg commented Mar 29, 2023

I agree with @chaen . Typical annoying case is the client installed in the CVMFS where the default config file is never used but rather the DIRACSYSCONFIG variable points to files for different installations.

@fstagni
Copy link
Contributor Author

fstagni commented Mar 30, 2023

OK, agreed. I coded a different solution, have a look (not super elegant, but I did not want to change too much of this very central code).

@fstagni fstagni changed the title [8.0] warning message when the default CFG file is not found or can't be loaded [8.0] print a warning message when no CFG file is found Mar 30, 2023
@fstagni fstagni merged commit 5bd4c66 into DIRACGrid:rel-v8r0 Jun 16, 2023
@DIRACGridBot DIRACGridBot added sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention labels Jun 16, 2023
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/5287088124

Failed:

  • integration
    cherry-pick 5bd4c66 into integration failed
    check merge conflicts on a local copy of this repository
    git fetch upstream
    git checkout upstream/integration -b cherry-pick-2-5bd4c6614-integration
    git cherry-pick -x -m 1 5bd4c6614
    # Fix the conflicts
    git cherry-pick --continue
    git commit --amend -m 'sweep: #6945 print a warning message when no CFG file is found' --author='fstagni <federico.stagni@cern.ch>'
    git push -u origin cherry-pick-2-5bd4c6614-integration
    
    # If you have the GitHub CLI installed the PR can be made with
    gh pr create \
         --label 'sweep:from rel-v8r0' \
         --base integration \
         --repo DIRACGrid/DIRAC \
         --title '[sweep:integration] print a warning message when no CFG file is found' \
         --body 'Sweep #6945 `print a warning message when no CFG file is found` to `integration`.
    
    Adding original author @fstagni as watcher.
    
    BEGINRELEASENOTES
    
    *Core
    FIX: print a warning message when no CFG file is found
    
    ENDRELEASENOTES
    Closes #7054'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR sweep:failed Sweeping failed and needs manual intervention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants