[8.0] Update dirac_cert_convert.py; Add guidance error message for user if unsupported crypto #7420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified dirac_cert_convert.py to allow pcks12 certificate with legacy crypto
Some providers (cf. CNRS) use certificates with outdated crypto,
so need to call `openssl` with the "-legacy" option.
Modified `dirac_cert_convert.py` to add a switch for this ("--legacy") using the `@Script` mechanisms.
Added the long option only, not putting the short option ("-l") since this should be exceptional.
Also added a gLogger.warn() for this.
…er if unsupported crypto Tell user to try "--legacy" option if the pcks12 file has old crypto. Also, corrected trailing whitespace, long lines, and other clean-ups after pylint.
|
You are still targeting integration: in #7420 I have cherry-picked your commit on top of rel-v8r0 branch (and fixed the syntax) |
Okay, thanks. Sorry about that. |
|
Sorry, I'm a bit lost... should I do something here? |
|
Nope, I just close this! Your changes are in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell user to try "--legacy" option if the pcks12 file has old crypto (addition or replacement for my previous pull request).
Also, corrected trailing white-space, long lines, and other clean-ups after pylint.