Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] fix SSHCE: clearer error message when output is not found #7655

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

aldbr
Copy link
Contributor

@aldbr aldbr commented Jun 7, 2024

Currently, when the SSHCE fails to get the output, we get the following error:

2024-06-06T11:44:40,902705Z WorkloadManagement/SiteDirectorDteam/ce.ce.ce ERROR: Invalid output from remote command
Traceback (most recent call last):
  File "/opt/dirac/versions/v9.0.0a29-1717652456/Linux-x86_64/lib/python3.11/site-packages/DIRAC/Resources/Computing/SSHComputingElement.py", line 511, in __executeHostCommand
    index = output.index("============= Start output ===============")
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: substring not found

The message is quite misleading.

  • I added a condition where output is empty
  • I removed the exception stack trace and the log when it is invalid

The SiteDirector is expected to print the S_ERROR message.

BEGINRELEASENOTES
*WorkloadManagement
FIX: remove exception log when output is not found
ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jun 7, 2024
@fstagni fstagni merged commit d922d22 into DIRACGrid:rel-v8r0 Jun 7, 2024
26 checks passed
@DIRACGridBot DIRACGridBot added the sweep:done All sweeping actions have been done for this PR label Jun 7, 2024
DIRACGridBot pushed a commit to DIRACGridBot/DIRAC that referenced this pull request Jun 7, 2024
@DIRACGridBot
Copy link

Sweep summary

Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/9420068098

Successful:

  • integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge sweep:done All sweeping actions have been done for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants