Fix for CVMFS locations lookup #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstagni
commented
Oct 27, 2023
fstagni
commented
Oct 27, 2023
fstagni
commented
Oct 27, 2023
| @@ -101,7 +106,7 @@ | |||
| "pilotRepo": "https://github.com/does_not_matter/Pilot.git", | |||
| "GenericPilotGroup": "gridpp_pilot", | |||
| "GenericPilotDN": "VAR_USERDN_GRIDPP", | |||
| "RemoteLogging": "True", | |||
| "RemoteLogging": "False", | |||
There was a problem hiding this comment.
@martynia this somehow does not work. Will be tested in other PR.
There was a problem hiding this comment.
That's strange . It works for me locally and in #217
There was a problem hiding this comment.
OK, now I see. You changed the schema and the test (obviously) failed. Now after "fixing" the test everything passes. A question remains why the original setting (with the remote logger ON) was not acceptable. This poses a potential problem when merging this and rebasing #217, where the logging is on by default.
|
@atsareg @martynia this is now really ready to be merged. All integration tests succeeded: https://github.com/fstagni/Pilot/actions/runs/6705655381 |
atsareg
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #215
Tests ran in https://github.com/fstagni/Pilot/actions/runs/6657162457