Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CVMFS locations lookup #216

Merged
merged 13 commits into from
Oct 31, 2023
Merged

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Oct 26, 2023

@@ -101,7 +106,7 @@
"pilotRepo": "https://github.com/does_not_matter/Pilot.git",
"GenericPilotGroup": "gridpp_pilot",
"GenericPilotDN": "VAR_USERDN_GRIDPP",
"RemoteLogging": "True",
"RemoteLogging": "False",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martynia this somehow does not work. Will be tested in other PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange . It works for me locally and in #217

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now I see. You changed the schema and the test (obviously) failed. Now after "fixing" the test everything passes. A question remains why the original setting (with the remote logger ON) was not acceptable. This poses a potential problem when merging this and rebasing #217, where the logging is on by default.

@fstagni
Copy link
Contributor Author

fstagni commented Oct 31, 2023

@atsareg @martynia this is now really ready to be merged. All integration tests succeeded: https://github.com/fstagni/Pilot/actions/runs/6705655381

@fstagni fstagni merged commit 4eb18f0 into DIRACGrid:devel Oct 31, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants