-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for CVMFS locations lookup #216
Conversation
@@ -101,7 +106,7 @@ | |||
"pilotRepo": "https://github.com/does_not_matter/Pilot.git", | |||
"GenericPilotGroup": "gridpp_pilot", | |||
"GenericPilotDN": "VAR_USERDN_GRIDPP", | |||
"RemoteLogging": "True", | |||
"RemoteLogging": "False", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@martynia this somehow does not work. Will be tested in other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's strange . It works for me locally and in #217
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now I see. You changed the schema and the test (obviously) failed. Now after "fixing" the test everything passes. A question remains why the original setting (with the remote logger ON) was not acceptable. This poses a potential problem when merging this and rebasing #217, where the logging is on by default.
@atsareg @martynia this is now really ready to be merged. All integration tests succeeded: https://github.com/fstagni/Pilot/actions/runs/6705655381 |
Superseeds #215
Tests ran in https://github.com/fstagni/Pilot/actions/runs/6657162457