Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote logging test -- and partial fixes. #218

Merged
merged 11 commits into from
Nov 9, 2023
Merged

Remote logging test -- and partial fixes. #218

merged 11 commits into from
Nov 9, 2023

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Nov 1, 2023 •
edited
Loading

closes #219

@fstagni fstagni mentioned this pull request Nov 1, 2023
Closed
@fstagni fstagni force-pushed the remoteLogging_test branch 7 times, most recently from d6e546a to 8f26c9e Compare November 3, 2023 16:12
fstagni
fstagni commented Nov 3, 2023
View reviewed changes
Pilot/pilotTools.py
@@ -849,7 +855,7 @@ def __init__(self):
self.pilotCFGFile = "pilot.json"
self.pilotLogging = False
self.loggerURL = None
self.loggerTimerInterval = 600
self.loggerTimerInterval = 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martynia and @sfayer double check this

@fstagni fstagni marked this pull request as ready for review November 3, 2023 19:51
@fstagni fstagni requested a review from martynia November 6, 2023 08:53
@fstagni fstagni marked this pull request as draft November 6, 2023 14:08
@fstagni fstagni removed the request for review from martynia November 6, 2023 14:08
@fstagni fstagni marked this pull request as ready for review November 6, 2023 19:47
@fstagni
Copy link
Contributor Author

fstagni commented Nov 8, 2023

@martynia and @atsareg final review of this? It will be merged anyway before tomorrow's hackathon.

@martynia
Copy link
Contributor

martynia commented Nov 8, 2023

Have you run your integration tests with RemoteLogger enabled ? I cannot see any log files on the server.

@fstagni
Copy link
Contributor Author

fstagni commented Nov 9, 2023

Have you run your integration tests with RemoteLogger enabled ? I cannot see any log files on the server.

Yes. Let's see later what's wrong, but maybe this time is on the server side.
I merge for the hackathon.

@fstagni fstagni merged commit 91949a8 into DIRACGrid:devel Nov 9, 2023
11 checks passed
@martynia
Copy link
Contributor

martynia commented Nov 9, 2023

Fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fstagni @martynia