fix(diracx-cli): adapt jobs cli to resolve issue with typer >= 0.12.4
#290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldbr
force-pushed
the
main_FIX_typer-0.12.4
branch
3 times, most recently
from
fd77587
to
ff1d02a
Compare
|
In order to verify this, please remove the |
aldbr
force-pushed
the
main_FIX_typer-0.12.4
branch
2 times, most recently
from
bcfe0ea
to
876b145
Compare
aldbr
force-pushed
the
main_FIX_typer-0.12.4
branch
from
876b145
to
8073c66
Compare
|
Images being rebuilt in https://github.com/DIRACGrid/container-images/actions/runs/10850586526 -- tests should be restarted then. |
|
I restarted the tests 3 days ago, it looks good! |
fstagni
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280
More details in fastapi/typer#943 (update: they won't solve the issue because we actually relied on a bug rather than a feature. So I adjusted our code accordingly)