Issue 147 postgres integration #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…greSQL using matrix note: Setted up chart github url to point to my fork, MUST change later
…imezone Mysql removes the timezone before inserting, but Postgresql throws an error
fstagni
reviewed
Sep 26, 2024
Comment on lines
+61
to
+66
| SubmissionTime = NullColumn("SubmissionTime", DateTime(timezone=True)) | ||
| RescheduleTime = NullColumn("RescheduleTime", DateTime(timezone=True)) | ||
| LastUpdateTime = NullColumn("LastUpdateTime", DateTime(timezone=True)) | ||
| StartExecTime = NullColumn("StartExecTime", DateTime(timezone=True)) | ||
| HeartBeatTime = NullColumn("HeartBeatTime", DateTime(timezone=True)) | ||
| EndExecTime = NullColumn("EndExecTime", DateTime(timezone=True)) |
There was a problem hiding this comment.
Why? We are anyway always using UTC.
There was a problem hiding this comment.
Is because we are specifying the timezone in datetime.now(tz=timezone.utc).
While this does not throw any errors in MySQL when the table does not accept a timezone, in PostgreSQL stops the execution due to conflicting formatting.
One way of fixing it is just to completely remove the timezone on the datetime.now function, which is not recommended and even RUFF marks it as a warning.
The other way is by telling the column to take into account the timezone, which in my opinion is the better way of implementing it.
MySQL:
- Changing the table property: 2024-09-26 14:00:32
- Removing
tz=timezone.utc: 2024-09-26 14:05:53
No change, both result in the same date format.
PostgreSQL:
- Changing the table property: 2024-09-26 13:50:26.213893+00
- Removing
tz=timezone.utc: 2024-09-26 13:55:57.840623
Timezone is or is not added at the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full integration with PostgreSQL
Used asyncpg as the driver because it is the fastest and one of the most used by the community
Had to change a few aspects that were MySQL specific. Those being unnamed Enums, which are not permitted in Postgres, and the way of returning the last inserted ID, which used result.lastrowid and postgres needs result.inserted_primary_key[0]