Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add H4N4 Modules #349

Closed
wants to merge 9 commits into from
Closed

Conversation

dromer
Copy link
Collaborator

@dromer dromer commented Aug 14, 2022

Atm have the osdialog patch on Wasted Audio fork. If good I'll make a PR upstream.

@dromer
Copy link
Collaborator Author

dromer commented Aug 14, 2022

Two minor things remaining.

In file included from h4n4-modules/src/tuning/Tunings.h:289,
                 from h4n4-modules/src/XenQnt.cpp:17:
h4n4-modules/src/tuning/TuningsImpl.h: In constructor ‘Tunings::Tuning::Tuning(const Tunings::Scale&, const Tunings::KeyboardMapping&, bool)’:
h4n4-modules/src/tuning/TuningsImpl.h:547:42: warning: ‘high’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  547 |                 octave_up ? s.tones[high - 1].cents + dt : s.tones[high - 1].floatValue - 1.0;
      |                                     ~~~~~^~~
h4n4-modules/src/tuning/TuningsImpl.h:545:43: warning: ‘low’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  545 |                 octave_down ? s.tones[low - 1].cents - dt : s.tones[low - 1].floatValue - 1.0;
      |                                       ~~~~^~~
h4n4-modules/src/tuning/TuningsImpl.h:528:22: warning: ‘oSP’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  528 |             for (int i = oSP + 1; i != oSP; i = (i + 1) % k.count)

@dromer dromer force-pushed the feature/h4n-modules branch from 105f5e3 to da7892a Compare August 14, 2022 18:09
@dromer dromer force-pushed the feature/h4n-modules branch from da7892a to 78fabc0 Compare August 14, 2022 18:13
@falkTX
Copy link
Contributor

falkTX commented Sep 8, 2022

Merged as 801a2cf

@falkTX falkTX closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants