Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sonusmodular #740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Sonusmodular #740

wants to merge 1 commit into from

Conversation

rl2939
Copy link
Contributor

@rl2939 rl2939 commented Nov 15, 2024

Update Sonusmodular to the latest version and adds the new module "Fluidmix" in the process.

@dromer
Copy link
Collaborator

dromer commented Nov 15, 2024

Nice! although somehow the plugin-validation is failing.

This needs some looking in to ..

@rl2939
Copy link
Contributor Author

rl2939 commented Nov 15, 2024

It seems to be coming from Tropicana. However, the only thing that changed from 2.0.0 to 2.1.0 for this module was the copyright year (https://gitlab.com/sonusdept/sonusmodular/-/commit/e5c89697af1af360da8ba63708b01f2a155db351?page=2).

From the plugin-validation:

[dpf] >>>>>>>>>>>>>>>>> LOADING module SonusModular : Tropicana
==162195== Conditional jump or move depends on uninitialised value(s)
==162195==    at 0x227E26C: set_frequency (sinosc.hpp:50)
==162195==    by 0x227E26C: set_sample_rate (sinosc.hpp:42)
==162195==    by 0x227E26C: set_sample_rate (sinosc.hpp:35)
==162195==    by 0x227E26C: SinOsc (sinosc.hpp:30)
==162195==    by 0x227E26C: TropAdd (tropadd.hpp:41)
==162195==    by 0x227E26C: Tropicana::Tropicana() (tropicana.cpp:68)
==162195==    by 0x227F76F: rack::CardinalPluginModel<Tropicana, TropicanaWidget>::createModule() (helpers.hpp:57)
==162195==    by 0xB74F0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==162195==    by 0xB93C43: plugin_idle (DistrhoUIInternal.hpp:231)
==162195==    by 0xB93C43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==162195==    by 0xA11568: main (DistrhoPluginJACK.cpp:1014)
==162195==  Uninitialised value was created by a heap allocation
==162195==    at 0x76B0E63: operator new(unsigned long) (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==162195==    by 0x227F764: rack::CardinalPluginModel<Tropicana, TropicanaWidget>::createModule() (helpers.hpp:57)
==162195==    by 0xB74F0F: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:568)
==162195==    by 0xB93C43: plugin_idle (DistrhoUIInternal.hpp:231)
==162195==    by 0xB93C43: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:901)
==162195==    by 0xA11568: main (DistrhoPluginJACK.cpp:1014)
==162195== 
{
   <insert_a_suppression_name_here>
   Memcheck:Cond
   fun:set_frequency
   fun:set_sample_rate
   fun:set_sample_rate
   fun:SinOsc
   fun:TropAdd
   fun:_ZN9TropicanaC1Ev
   fun:_ZN4rack19CardinalPluginModelI9Tropicana15TropicanaWidgetE12createModuleEv
   fun:_ZN15CardinalDISTRHO10CardinalUI6uiIdleEv
   fun:plugin_idle
   fun:_ZN15CardinalDISTRHO12runSelfTestsEv
   fun:main
}
[dpf] >>>>>>>>>>>>>>>>> LOADING moduleWidget SonusModular : Tropicana
[182.921 info Rack/src/window/Svg.cpp:28 loadFile] Loaded SVG /home/runner/work/Cardinal/Cardinal/src/Rack/../../plugins/sonusmodular/res/tropicana.svg
[dpf] >>>>>>>>>>>>>>>>> ADDING TO ENGINE SonusModular : Tropicana
[dpf] >>>>>>>>>>>>>>>>> ADDING TO RACK VIEW SonusModular : Tropicana
[dpf] >>>>>>>>>>>>>>>>> REMOVING FROM RACK VIEW SonusModular : Tropicana
[dpf] >>>>>>>>>>>>>>>>> DELETING module + moduleWidget SonusModular : Tropicana

@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

yeah the changes dont seem relevant here, so not sure why this fails now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants