feat(route): add cffex/announcement #16258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyRL
reviewed
Jul 25, 2024
lib/routes/cffex/announcement.ts
Outdated
|
|
||
| export const route: Route = { | ||
| path: '/announcement', | ||
| name: '中国金融期货交易所 - 交易所公告', |
There was a problem hiding this comment.
Suggested change
| name: '中国金融期货交易所 - 交易所公告', | |
| name: '交易所公告', |
Do not include namespace's name in route name
lib/routes/cffex/announcement.ts
Outdated
| maintainers: ['ChenXiangcheng1'], | ||
| example: '/cffex/announcement', | ||
| parameters: {}, | ||
| description: `欢迎订阅!!! 我维护的 cffex 交易所公告!!! `, |
There was a problem hiding this comment.
Suggested change
| description: `欢迎订阅!!! 我维护的 cffex 交易所公告!!! `, |
lib/routes/cffex/announcement.ts
Outdated
| radar: [ | ||
| { | ||
| source: ['cffex.com.cn'], | ||
| target: '/cffex/announcement', |
There was a problem hiding this comment.
Suggested change
| target: '/cffex/announcement', | |
| target: '/announcement', |
lib/routes/cffex/announcement.ts
Outdated
Comment on lines
37
to
39
| const response = await ofetch(homeUrl, { | ||
| headers: {}, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const response = await ofetch(homeUrl, { | |
| headers: {}, | |
| }); | |
| const response = await ofetch(homeUrl); |
lib/routes/cffex/announcement.ts
Outdated
Comment on lines
47
to
48
| const a1 = $(item).find('a').first(); | ||
| const a2 = $(item).find('a').eq(1); |
There was a problem hiding this comment.
Please use descriptive variables
lib/routes/cffex/announcement.ts
Outdated
| item.description = $('div.jysggnr div.nan p').eq(1)?.html(); | ||
| return item; | ||
| }, | ||
| 3600, |
There was a problem hiding this comment.
Use the default config.cache.contentExpire instead of a hard-coded value.
lib/routes/cffex/announcement.ts
Outdated
| return item; | ||
| }, | ||
| 3600, | ||
| true |
There was a problem hiding this comment.
No need to specify the default value
lib/routes/cffex/announcement.ts
Outdated
| ); | ||
|
|
||
| return { | ||
| title: `中国金融期货交易所 - 交易所公告`, |
There was a problem hiding this comment.
Suggested change
| title: `中国金融期货交易所 - 交易所公告`, | |
| title: '中国金融期货交易所 - 交易所公告', |
|
Route test it works well locally. |
wonktondI
pushed a commit
to wonktondI/RSSHub
that referenced
this pull request
Jul 28, 2024
* feat(route): add cffex/announcement * style(route/cffex): modify code style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
N/A
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
PuppeteerNote / 说明
我的第一个 PR !!!