-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new AQ mode #17
Merged
Merged
add new AQ mode #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
reviewed
Feb 17, 2022
source/x265cli.cpp
Outdated
H0(" --[no-]hevc-aq Mode for HEVC Adaptive Quantization. Default %s\n", OPT(param->rc.hevcAq)); | ||
H0(" --aq-strength <float> Reduces blocking and blurring in flat and textured areas (0 to 3.0). Default %.2f\n", param->rc.aqStrength); | ||
H0(" --aq-bias-strength <float> Sets the bias to dark strength in AQ modes 3 and 5. Default %.2f\n", param->rc.aqBiasStrength); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently that line lacks few spaces at beginning, otherwise it can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed now.
DJATOM
pushed a commit
that referenced
this pull request
Sep 24, 2022
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
pushed a commit
that referenced
this pull request
Jun 10, 2023
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
pushed a commit
that referenced
this pull request
Jun 10, 2023
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
pushed a commit
that referenced
this pull request
Apr 28, 2024
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
pushed a commit
that referenced
this pull request
Aug 31, 2024
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
DJATOM
pushed a commit
that referenced
this pull request
Sep 2, 2024
add new AQ mode This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this is the right branch to open a PR for.
This just adds AQ mode 3's dark bias to AQ mode 4. Because of normal AQ strength values for mode 4 not really working well with the dark bias, an additional bias-strength parameter has been added.