Initial implementation of gWCS slicing machinery, using ExpressionTree modification #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 97.04% 97.96% +0.91%
==========================================
Files 12 14 +2
Lines 406 589 +183
==========================================
+ Hits 394 577 +183
Misses 12 12
Continue to review full report at Codecov.
|
Cadair
force-pushed
the
gwcs_slicing
branch
2 times, most recently
from
be36092
to
afdee44
Compare
This code drops branches from ExpressionTrees to remove inputs (and their corresponding outputs) from the model. The idea is to use this when slicing the gwcs object.
Cadair
changed the title
It only works if you only have one frame on the way in, but should otherwise be ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code drops branches from ExpressionTrees to remove inputs (and their corresponding outputs) from the model. The idea is to use this when slicing the gwcs object.