Fix lon_pole units in VaryingCelestialTransform #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 37 37
Lines 2095 2095
=======================================
Hits 2036 2036
Misses 59 59
|
nabobalis
commented
Feb 20, 2023
| @@ -46,6 +46,19 @@ def test_generate_celestial_unitless(): | |||
| assert u.allclose(shift1.offset, 0) | |||
|
|
|||
|
|
|||
| def test_varying_transform_no_lon_pole_unit(): | |||
There was a problem hiding this comment.
If you prefer, I can remove this test and add the unit check to the test below and remove the lon_pole argument in the VaryingCelestialTransform call.
I can also add a test for generate_celestial_transform instead? Or both?
nabobalis
commented
Feb 20, 2023
3 tasks
Cadair
reviewed
Apr 27, 2023
|
|
I re-pointed our intersphinx to stable, but maybe we can fix this before release. |
|
Thanks a lot @nabobalis 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a simple test.
Not sure if there is something else to do.