Bug fixes and cleanup on gwcs slicing and dataset creation #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 99.54% 99.26% -0.28%
==========================================
Files 14 13 -1
Lines 655 679 +24
==========================================
+ Hits 652 674 +22
- Misses 3 5 +2
Continue to review full report at Codecov.
|
This fixes issues with renumbering axes in the output frame as well as allowing slicing out non-separable axes if all those axes are being sliced out (i.e. slicing out both of the spatial axes in a DS)
We have an isort config which does it better
This reverts commit db2f022.
Cadair
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.